Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Update "latest" meta-schemas to draft-06 #103

Merged
merged 1 commit into from
May 10, 2017

Conversation

handrews
Copy link
Contributor

@handrews handrews commented May 9, 2017

@adamvoss
Copy link
Contributor

adamvoss commented May 9, 2017

Are links and interfaces orphans or do they also need to be updated?

This is probably not the place for it, but the example schemas (geo, card, calendar, and address) also still indicate draft-04.

@handrews
Copy link
Contributor Author

handrews commented May 9, 2017

links is in the diff (and in the draft-06 directory- I literally did "cp draft-06/* .; git commit -a")

I had never even noticed interfaces. I had to go back to the old repo to find it, and it hadn't been touched for 7 years. I'd say file a new issue on it and give people time to explain a use case. If no one really wants to own it I'd rather nuke it. It's not exactly complex, and there's a large ecosystem of code generation tools out there and I doubt any of them use this.

Updating the example schemas would also be a separate issue/PR. Feel free to file either :-), going straight to PR is fine with me.

@adamvoss
Copy link
Contributor

adamvoss commented May 9, 2017

My bad on missing 'links'. I opened #106 regarding 'interfaces'. Acted too quickly on that as well, re-reading your message I should have just opened a PR deleting it... time to get some more sleep :-)

@handrews
Copy link
Contributor Author

handrews commented May 9, 2017

@awwright @Relequestual @Julian this is a trivial mechanical change for a problem that is confusing people who would otherwise implement draft-06, any objections? While I'd prefer an active approval and would usually wait for one, given that this is just a bug fix of copying files, if no one objects today I'll consider @vossad01's review sufficient and merge this.

@Julian
Copy link
Member

Julian commented May 9, 2017

@handrews +1

@Relequestual Relequestual merged commit 899ee61 into json-schema-org:master May 10, 2017
@Relequestual
Copy link
Member

MIght as well do something useful while compiling stuff from source -_-

@handrews handrews deleted the latest branch May 22, 2018 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants