Skip to content

Add boundary cases for integers #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add boundary cases for integers #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea81e51
Add boundary cases for integers
hudlow May 20, 2025
fe9a287
Adjust integer boundary tests based on review feedback
hudlow May 29, 2025
1f81212
Fix linting issues
hudlow May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/draft-next/optional/bignum.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@
"description": "a negative bignum is an integer",
"data": -12345678910111213141516171819202122232425262728293031,
"valid": true
},
{
"description": "a bignum with a nonzero-value fractional part is not an integer",
"data": 12345678910111213141516171819202122232425262728293031.5,
"valid": false
}
]
},
Expand Down
201 changes: 201 additions & 0 deletions tests/draft-next/optional/integer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,201 @@
[
{
"description": "binary64 float (double) truncation",
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"type": "integer"
},
"tests": [
{
"description": "a small float whose fractional part is truncated is not an integer",
"data": 1.00000000000001,
"valid": false
},
{
"description": "a large float whose fractional part is truncated is not an integer",
"data": 9007199254740991.5,
"valid": false
}
]
},
{
"description": "maximum signed 32-bit integer comparison",
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"minimum": 2147483647,
"maximum": 2147483647
},
"tests": [
{
"description": "comparison is true for equal numbers",
"data": 2147483647,
"valid": true
},
{
"description": "comparison is false for inequal numbers",
"data": 2147483646,
"valid": false
}
]
},
{
"description": "minimum signed 32-bit integer comparison",
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"minimum": -2147483648,
"maximum": -2147483648
},
"tests": [
{
"description": "comparison is true for equal numbers",
"data": -2147483648,
"valid": true
},
{
"description": "comparison is false for inequal numbers",
"data": -2147483647,
"valid": false
}
]
},
{
"description": "maximum unsigned 32-bit integer comparison",
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"minimum": 4294967295,
"maximum": 4294967295
},
"tests": [
{
"description": "comparison is true for equal numbers",
"data": 4294967295,
"valid": true
},
{
"description": "comparison is false for inequal numbers",
"data": 4294967294,
"valid": false
}
]
},
{
"description": "ECMAScript Number.MAX_SAFE_INTEGER (2^53-1) comparison",
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"minimum": 9007199254740991,
"maximum": 9007199254740991
},
"tests": [
{
"description": "comparison is true for equal numbers",
"data": 9007199254740991,
"valid": true
},
{
"description": "comparison is false for inequal numbers",
"data": 9007199254740990,
"valid": false
}
]
},
{
"description": "ECMAScript Number.MIN_SAFE_INTEGER (-2^53-1) comparison",
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"minimum": -9007199254740991,
"maximum": -9007199254740991
},
"tests": [
{
"description": "comparison is true for equal numbers",
"data": -9007199254740991,
"valid": true
},
{
"description": "comparison is false for inequal numbers",
"data": -9007199254740990,
"valid": false
}
]
},
{
"description": "maximum signed 64-bit integer comparison",
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"minimum": 9223372036854775807,
"maximum": 9223372036854775807
},
"tests": [
{
"description": "comparison is true for equal numbers",
"data": 9223372036854775807,
"valid": true
},
{
"description": "comparison is false for inequal numbers",
"data": 9223372036854775806,
"valid": false
}
]
},
{
"description": "minimum signed 64-bit integer comparison",
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"minimum": -9223372036854775808,
"maximum": -9223372036854775808
},
"tests": [
{
"description": "comparison is true for equal numbers",
"data": -9223372036854775808,
"valid": true
},
{
"description": "comparison is false for inequal numbers",
"data": -9223372036854775807,
"valid": false
}
]
},
{
"description": "maximum unsigned 64-bit integer comparison",
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"minimum": 18446744073709551615,
"maximum": 18446744073709551615
},
"tests": [
{
"description": "comparison is true for equal numbers",
"data": 18446744073709551615,
"valid": true
},
{
"description": "comparison is false for inequal numbers",
"data": 18446744073709551614,
"valid": false
}
]
},
{
"description": "maximum unsigned 128-bit integer comparison",
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"minimum": 340282366920938463463374607431768211455,
"maximum": 340282366920938463463374607431768211455
},
"tests": [
{
"description": "comparison is true for equal numbers",
"data": 340282366920938463463374607431768211455,
"valid": true
},
{
"description": "comparison is false for inequal numbers",
"data": 340282366920938463463374607431768211454,
"valid": false
}
]
}
]
24 changes: 22 additions & 2 deletions tests/draft-next/type.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,32 @@
"valid": true
},
{
"description": "a float with zero fractional part is an integer",
"description": "a negative integer is an integer",
"data": -1,
"valid": true
},
{
"description": "zero is an integer",
"data": 0,
"valid": true
},
{
"description": "negative zero is an integer",
"data": -0,
"valid": true
},
{
"description": "a float with a zero-value fractional part is an integer",
"data": 1.0,
"valid": true
},
{
"description": "a float is not an integer",
"description": "a float with an exponent and zero-value fractional part is an integer",
"data": 1.1e1,
"valid": true
},
{
"description": "a float with a nonzero-value fractional part is not an integer",
"data": 1.1,
"valid": false
},
Expand Down
5 changes: 5 additions & 0 deletions tests/draft2019-09/optional/bignum.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@
"description": "a negative bignum is an integer",
"data": -12345678910111213141516171819202122232425262728293031,
"valid": true
},
{
"description": "a bignum with a nonzero-value fractional part is not an integer",
"data": 12345678910111213141516171819202122232425262728293031.5,
"valid": false
}
]
},
Expand Down
Loading
Loading