Test annotation tests automation #769
Conversation
jdesrosiers
force-pushed
the
annotation-tests
branch
from
4aebe43 to
ed9d7b0
Compare
jdesrosiers
force-pushed
the
annotation-tests
branch
2 times, most recently
from
0aa5d6d to
222eb12
Compare
|
Sorry. Thought I was testing this on my fork. Actual PR coming soon. |
| "instance": {}, | ||
| "assertions": [ | ||
| { | ||
| "location": "/foo", |
There was a problem hiding this comment.
What location does this represent? I assume the instance, but there's schema location. There's also evaluation path that we could consider. I'm not sure evaluation path is necessary, but the other two should both be present, I think.
Secondly, it's inconsistent. Some are uri-encoded, and others aren't.
| "expected": [] | ||
| }, | ||
| { | ||
| "location": "/3", |
There was a problem hiding this comment.
Why is this location included? The instance location doesn't exist.
|
@gregsdennis Thanks for the quick review, but it will be easier to wait until I make a proper PR. I had meant to create this on my fork for the purpose of testing the github action, but I was tired and accidentally created it here instead. The actual intended PR is coming soon. |
No description provided.