Skip to content

Add tests for propertyNames with const/enum #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

michaelmior
Copy link
Contributor

This checks for the correct functioning of propertyNames with a const or enum schema.
This inspired by a bug reported in the Blaze validator for this specific case.

@michaelmior michaelmior requested a review from a team as a code owner February 10, 2025 21:06
@karenetheridge
Copy link
Member

I'm curious what this implementation did to cause those particular keywords to not work properly?

@jviotti
Copy link
Member

jviotti commented Feb 10, 2025

@karenetheridge It was totally an oversight. The code for enum/const would not take into consideration the fact that the target could be a key and not the instance, like in other keywords.

@Julian Julian merged commit 83e866b into json-schema-org:main Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants