test: hostname format check fails on empty string #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert that hostname format validation fails gracefully on empty strings. This is especially for Python `jsonschema` library that raises an unexpected ValueError exception on `hostname` check (python-jsonschema/jsonschema#1121). Adds similar test for: * draft3: host-name * draft4: hostname * draft6: hosntame * draft7: hostname, idn-hostname * draft2019-09: hostname, idn-hostname * draft2020-12: hostname, idn-hostname * draft-next: hostname, idn-hostname
|
Nice, thanks for finishing this off, appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR for #677 (resolves #677).
I've picked up the original work and preserved the original commit (singular) with a merge-back of
mainto resolve conflicts.Based on the thread contents there and my own reading of RFC 1123, empty strings should not be allowed.
Using my own judgement -- which I believe matches @Julian's comments in the #677 thread -- I believe that this should apply to the earlier drafts as well, even though their definitions of the
hostnameformats refer to RFC 1034.1034 does not appear to be an appropriate source for validation behaviors, as it defines a broader category of values than hostnames.1
Footnotes
I actually think this is badly wrong enough that the correct course of action is to correct past drafts to reference RFC 1123, but I don't know what the process for doing so would be. ↩