Add valid first character to avoid Bidi rule violation in Arabic-Indic digits test #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am sorry, I probably should have created an issue first... If the issue is required - please, let me know. I will create it and link it to the PR |
|
Issue has been created |
Julian
approved these changes
Apr 30, 2024
|
I ran these against my implementation, and it seems my implementation apparently doesn't do IDN hostname validation well: these fail both before and after the changes for me. (It's fine, they're optional.) |
|
I pass the previous IDN hostname tests. I'll give this one a go tomorrow. |
Hi, @mwadams. Could you please advise if you had a chance to try the updated test case? |
|
Hi - I can confirm that Corvus.JsonSchema still passes the test with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR resolves #737