Tests for dependentSchema and propertyDependencies with unevaluatedPro…

[Vinit-Pandit]

adding tests for dependentSchema and propertyDependencie with unevaluatedProperties and additionalProperties
refer this issue #626

[gregsdennis]

I think these need to be split up differently.

The thing we're testing here is additionalProperties and unevaluatedProperties. The tests should go in those files.

Also, we also need a dependentSchemas test for draft-next.

[Vinit-Pandit]

Feww..! GREEN :)

[gregsdennis]

The files look fine, but I think we need more test cases for each scenario. What does a passing instance look like? What if the nested subschemas themselves do declare properties? Etc.

[Vinit-Pandit]

Please review this

[gregsdennis]

Looks like we need a few new test scenarios that define foo as a property. Apply those changes to all drafts as well, please.

[Vinit-Pandit]

The files look fine, but I think we need more test cases for each scenario. What does a passing instance look like? What if the nested subschemas themselves do declare properties? Etc.

Got it! I misunderstood the test cases as a test. I'm really sorry about that. If I understand correctly, I should add more test cases that cover the inner schemas as well. Are the test cases I added before your this comment still fine to keep?

[Vinit-Pandit]

This one

{
        "description": "dependent schema with additionalProperties",
        "schema": {
            "$schema": "https://json-schema.org/draft/2019-09/schema",
            "dependentSchemas": {
                "foo": {}
            },
            "additionalProperties": false
        },
        "tests": [
            {
                "description": "dependentSchemas properties are counted as additional properties",
                "data": {
                    "foo": ""
                },
                "valid": false
            }
        ]
    }

[gregsdennis]

I misunderstood the test cases as a test.

No, you didn't misunderstand. What you have is good, except for the test cases I commented on. For those, we need schemas like the one I showed.

You'll also need to rebase this branch since I merged another PR.

[gregsdennis]

The test scenarios look good to me. All the tests pass against my implementation. 🎉

Just a few descriptions to update. Thanks for the work on this.

[Vinit-Pandit]

I just realize it after 5 commits that i can add the suggested changes in batch and then commit them in once 😅 , should i squash them into once ?