Skip to content

Test for $ref with $recursiveAnchor #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

Vinit-Pandit
Copy link
Contributor

Test that verifies that $ref is not affected by $recursiveAnchor , addresing this issue #296

@Vinit-Pandit Vinit-Pandit requested a review from a team as a code owner April 10, 2024 03:56
@gregsdennis
Copy link
Member

gregsdennis commented Apr 10, 2024

@MeastroZI when you force-push, it's difficult to review what changed. Please just add a new commit next time.

If you're incorporating others' recommendations, it's actually a good idea to just merge directly from the suggestion comment.

@Vinit-Pandit
Copy link
Contributor Author

Vinit-Pandit commented Apr 10, 2024

@MeastroZI when you force-push, it's difficult to review what changed. Please just add a new commit next time.

If you're incorporating others' recommendations, it's actually a good idea to just merge directly from the suggestion comment.

Oo noted. I've learned a new good practice from you. Thank you, Greg Dennis

@Vinit-Pandit
Copy link
Contributor Author

Please let me know if this PR requires any changes. Otherwise, I kindly request to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants