-
-
Notifications
You must be signed in to change notification settings - Fork 215
Updates min/maxLenth tests to mention graphemes rather than unicode code points #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the language for the test that verifies that one grapheme is too short when checked against minLength of 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming I understand the terms "code point" and "grapheme" correctly, I think this change is correct.
This came up when working on my java implementation here: https://github.com/openapi-json-schema-tools/openapi-json-schema-generator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this, but I'd like to see if @Julian has any strong feelings about this.
Looks good to me too, just change it in the other drafts too |
Oh! Please also check for |
Maybe we should pick some characters that actually make sense -- as far as I can tell "\uD83D\uDCA9" isn't valid utf8. I did some digging in the history and the test was added here: #52 - and indeed this is UTF-16, not UTF-8. we should fix that. The proper sequence for the poop emoji, that should appear in the file, is |
No, JSON requires that it be broken out into the surrogate pair.
|
@spacether Just wanted to make sure you saw this request to add this change to other drafts as well. |
Updates min/maxLenth tests to mention graphemes rather than unicode points
Updates the language for the test that verifies that one grapheme is too short when checked against minLength of 2