test/refRemote: anchor within remote ref #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both of these pass on my implementation 👍. Thanks @santhosh-tekuri! Could you also add them to the |
|
@gregsdennis added in |
gregsdennis
approved these changes
Feb 26, 2023
|
Thanks, yep, looks good to me too. |
|
I also added this to the referencing-suite where it seems I forgot it -- if you're working on a new referencing implementation you might be interested in that suite until I get the time to do python-jsonschema/referencing-suite#3 and copy its tests here to this suite. |
| { | ||
| "description": "anchor within remote ref", | ||
| "schema": { | ||
| "$schema": "https://json-schema.org/draft/2010-09/schema", |
There was a problem hiding this comment.
This is an incorrect URI. Any tests that try to use this schema ought to be failing due to the missing resource.
There was a problem hiding this comment.
just raised PR #644 to fix this
Julian
added a commit
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the test is valid, then I will add the same for remaining drafts in this PR