Skip to content

Add tests for some more differing URI scenarios. #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

Julian
Copy link
Member

@Julian Julian commented Aug 29, 2022

Covers:

* A $ref to an absolute URI present in the retrieved schema
* A schema with URN $id with a nested $ref
* Retrieving a schema with a different $id than the retrieval URI
* Retrieving a schema with $ref whose retrieval URI was an HTTP URI
  but whose $id is an URN

(These involve sibling $refs so don't apply to pre-2019).

Missing is a test for an URN retrieval URL, which unfortunately we have
no way of communicating at the minute.

Refs: #578 (comment)

Covers:

    * A $ref to an absolute URI present in the retrieved schema
    * A schema with URN $id with a nested $ref
    * Retrieving a schema with a different $id than the retrieval URI
    * Retrieving a schema with $ref whose retrieval URI was an HTTP URI
      but whose $id is an URN

(These involve sibling $refs so don't apply to pre-2019).

Missing is a test for an URN retrieval URL, which unfortunately we have
no way of communicating at the minute.

Refs: #578 (comment)
@Julian Julian requested a review from a team as a code owner August 29, 2022 09:46
@gregsdennis
Copy link
Member

gregsdennis commented Aug 29, 2022

I'll let others speak to the correctness of these tests (I'm not good with URIs), but these tests all pass on my implementation.

@karenetheridge
Copy link
Member

they pass here too.

@Julian
Copy link
Member Author

Julian commented Sep 8, 2022

Thanks both.

@Julian Julian merged commit ed0b855 into main Sep 8, 2022
@Julian Julian deleted the differing-uris branch September 8, 2022 05:56
@Julian
Copy link
Member Author

Julian commented Sep 8, 2022

Sorry, I guess I see @karenetheridge you didn't comment on the tests themselves either... Can you speak up if you (or anyone) has comments on the tests (I suppose now which I can address in a follow up)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants