Cross draft tests #587
Merged
Cross draft tests #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please could you rebase with |
|
Odd. I thought I pulled before making changes. |
gregsdennis
force-pushed
the
cross-draft-tests
branch
from
3837f6f to
52eb279
Compare
|
Thanks! These seem good to go, appreciated! |
Julian
added a commit
to python-jsonschema/jsonschema
that referenced
this pull request
Aug 16, 2022
In other words, a draft 7 schema may reference a draft 2019 schema (or vice versa), and now correctly apply the 2019 rules within the referenced schema. Refs: json-schema-org/JSON-Schema-Test-Suite#587
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
May 16, 2023
This test references draft2019-09, which isn't supported. Introduced here: json-schema-org/JSON-Schema-Test-Suite#587
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
May 16, 2023
This test references draft2019-09, which isn't supported. Introduced here: json-schema-org/JSON-Schema-Test-Suite#587
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
May 22, 2023
This test references draft2019-09, which isn't supported. Introduced here: json-schema-org/JSON-Schema-Test-Suite#587
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
May 26, 2023
This test references draft2019-09, which isn't supported. Introduced here: json-schema-org/JSON-Schema-Test-Suite#587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #210
I've put these in optional for now. My validator passes all of them, though.
The approach was to create two remotes: one that uses a new keyword in that draft, and one that uses a new keyword in the next draft (which should be ignored).
Then tests just reference those remotes and check to see if those keywords are processed accordingly.