test the format-assertion vocabulary with a custom metaschema #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenetheridge
force-pushed
the
ether/custom-dialect
branch
from
8a49237 to
ff516ef
Compare
karenetheridge
force-pushed
the
ether/custom-dialect
branch
from
ff516ef to
5f5fccd
Compare
ChALkeR
reviewed
Sep 27, 2021
jdesrosiers
approved these changes
Sep 28, 2021
Comment on lines
+16
to
+18
| "description": "format-assertion: false: invalid string", | ||
| "data": "not-an-ipv4", | ||
| "valid": false |
There was a problem hiding this comment.
The results for this test depend on whether the implementation supports the format-assertion vocabulary or not. That's fine considering that this is in "optional", but it might be nice to have a $comment or something that this is the expected result for an implementation that does support the format-assertion vocabulary. Implementations that don't support format-assertion will not error, but will return different result.
There was a problem hiding this comment.
we should probably do that for everything in optional/... I think there's an old issue asking for an expanded README too.
Maybe after the conference is done we can have some discussions about how to improve the layout of the test suite?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our very first test using a custom metaschema. Luckily, since format-assertion is not enabled in the default metaschema, we can enable it here and use it to test the effectiveness of the $schema and $vocabulary keywords.