Skip to content

Add tests for $dynamicRef/$dynamicAnchor #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2021
Merged

Add tests for $dynamicRef/$dynamicAnchor #462

merged 1 commit into from
Mar 26, 2021

Conversation

jdesrosiers
Copy link
Member

The tests that were there originally were copied and adapted from the 2019-09 test. While those tests are valid, I thought it would be easier for people to follow this complicated concept by having just a few examples that are changed slightly to cover all the normal cases and edges cases related to these keywords. That ended up creating some duplication between some of the old tests with some of the new tests. I favored the new tests over the old ones when there was conflict.

The diff is completely useless on this one. I suggest ignoring it.

@jdesrosiers
Add tests for $dynamicRef/$dynamicAnchor
ff9f22e 
What was there originally was copied and adapted from the 2019-09 test.
While those tests are valid, I thought it would be easier for people to
follow this complicated concept by having just two examples that are
changed slightly to cover all the normal cases and edges cases related
to these keywords. That ended up creating some duplication between some
of the old tests with some of the new tests. I favored the new tests
over the old ones when there was conflict.
@jdesrosiers jdesrosiers mentioned this pull request Mar 15, 2021
Closed
@jdesrosiers
Copy link
Member Author

@gregsdennis, have you had a chance to try these test against your implementation?

It would also be great to get feeback from @ssilverman, @rjmill and anyone else who has been working on implementation or has at least been thinking about these keywords (@karenetheridge maybe? Don't know if you've gotten to these yet).

This has been stale for 2 weeks and I'd like to get it merged soon.

@karenetheridge
Copy link
Member

I haven't finished a draft202012 implementation yet, but have no problem with these tests being merged now and then I can complain later if something doesn't look right :)

@gregsdennis
Copy link
Member

I'm fairly certain that I've looked at this. I think I mentioned it in Slack somewhere. I found bugs 😃.

@jdesrosiers
Copy link
Member Author

There don't seem to be any objections, so I'll merge tomorrow even if I don't see an explicit review approval unless someone objects.

@karenetheridge karenetheridge requested a review from a team March 25, 2021 21:29
karenetheridge
karenetheridge approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@karenetheridge karenetheridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's an explicit approval :)

@jdesrosiers jdesrosiers merged commit 77f1d10 into json-schema-org:master Mar 26, 2021
@jdesrosiers jdesrosiers deleted the dynamic-ref-tests branch March 26, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenetheridge karenetheridge karenetheridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdesrosiers @karenetheridge @gregsdennis