Remove remotes from bin/jsonschema_suite

[amosonn]

Now it fetches them from the filesystem for serving, checking and displaying.

Two open questions:

1. Is the dump_remotes command even necessary now? I didn't remove it so it doesn't break anything, but it is now reduced to copying a file tree.
2. It would be cool if we could also verify that the remotes are valid schemas. The question is of course, for which draft? The only idea I've had so far was to make them available in a similar structure to the tests, under directories for each draft. This is a bit cumbersome (though they could mostly just be symlinked from elsewhere), the advantage is that they can be properly checked and then only used from relevant draft versions. This does require changing the serve infrastructure, either to accept a draft name and serve only the relevant remotes, or to serve them in sub-directories, which requires changes to the tests as well.

[Julian]

Hi! Awesome, thanks so much for trying to tackle this it's gone unfixed for too long... I have to give it a closer look, but let's see if I can answer either question firstly...:

Is the dump_remotes command even necessary now? I didn't remove it so it doesn't break anything, but it is now reduced to copying a file tree.

Honestly I don't know if anyone uses this at this point, the person who originally asked for it was about 6 years ago and the only person who ever wanted it :) -- in theory the point is encapsulation -- even though as you say right now it's just copying a directory, in the future that may not be the case for whatever reason, so having it provides a public API vs saying "rely on the directory layout". Of course on the other hand, we still haven't done #223, so ... yeah I don't know, my inclination is still to leave it for now rather than thinking too hard but obviously thoughts welcome.

[Julian]

Cool! I think this looks great to me! Will see if you have any comments but then this may well be ready to merge.