Add tests for location-independent identifiers in remote ref #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notEthan
reviewed
Feb 3, 2021
notEthan
reviewed
Feb 3, 2021
Julian
added a commit
that referenced
this pull request
Jun 21, 2022
|
Sorry this took so long :/ but yeah, merged. Appreciated! |
|
Thank you! |
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
May 16, 2023
This will keep using the same draft for any remote `$ref` schemas that don't explicitly set `$schema`. It's necessary so that we know which keywords to use for things that have changed between drafts (eg, `id` vs. `$id`). Exposed by: json-schema-org/JSON-Schema-Test-Suite#454
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
May 16, 2023
This will keep using the same draft for any remote `$ref` schemas that don't explicitly set `$schema`. It's necessary so that we know which keywords to use for things that have changed between drafts (eg, `id` vs. `$id`). Exposed by: json-schema-org/JSON-Schema-Test-Suite#454
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
May 22, 2023
This will keep using the same draft for any remote `$ref` schemas that don't explicitly set `$schema`. It's necessary so that we know which keywords to use for things that have changed between drafts (eg, `id` vs. `$id`). Exposed by: json-schema-org/JSON-Schema-Test-Suite#454
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
May 26, 2023
This will keep using the same draft for any remote `$ref` schemas that don't explicitly set `$schema`. It's necessary so that we know which keywords to use for things that have changed between drafts (eg, `id` vs. `$id`). Exposed by: json-schema-org/JSON-Schema-Test-Suite#454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As briefly discussed in Slack, here are tests that verify that location-independent identifiers work when they are inside a remote schema.