More optional ipv6 tests #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leading/traling whitespace is invalid Netmask is not a part of ipv6 address. Zone id is not a part of ipv6 address.
Julian
reviewed
Jul 29, 2020
| }, | ||
| { | ||
| "description": "zone id is not a part of ipv6 address", | ||
| "data": "fe80::a%eth1", |
There was a problem hiding this comment.
Oy, looks like inet_pton / AF_INET6 happily accepts zone IDs, which is how I assume most folks have actually implemented IPv6 validation...
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
Oct 21, 2021
Fixes a new test failure from: json-schema-org/JSON-Schema-Test-Suite#420 `IPAddr` allows passing netmask, which we don't want.
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
Apr 22, 2022
Fixes a new test failure from: json-schema-org/JSON-Schema-Test-Suite#420 `IPAddr` allows passing netmask, which we don't want.
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
May 15, 2023
Fixes a new test failure from: json-schema-org/JSON-Schema-Test-Suite#420 `IPAddr` allows passing netmask, which we don't want.
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
May 16, 2023
Fixes a new test failure from: json-schema-org/JSON-Schema-Test-Suite#420 `IPAddr` allows passing netmask, which we don't want.
davishmcclurg
added a commit
to davishmcclurg/json_schemer
that referenced
this pull request
May 22, 2023
Fixes a new test failure from: json-schema-org/JSON-Schema-Test-Suite#420 `IPAddr` allows passing netmask, which we don't want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: