[25] Add an "Optional Tests" section to the README #345
Conversation
| Optional Tests | ||
| -------------- | ||
|
|
||
| Tests in the `optional/` directory test optional validation behavior. Validators |
There was a problem hiding this comment.
Thanks! I was hoping to even say a bit about each of the files present here -- e.g. a list of each file we have, and an explanation/link to why it's optional (e.g., for zeroTerminatedFloats.json, it's for languages that do not have floating point types. For format, it's because it being a validation keyword rather than informative is optional, etc.
This way there's a short sentence about each and a list of why they're not required.
Does that make sense?
There was a problem hiding this comment.
Could this be put into the test data itself, either in the 'description' field or in an additional 'comment' field?
|
I can complete this and propose new words as soon as we resolve json-schema-org/json-schema-spec#898. In the meantime, I've pushed a latest draft. |
ssilverman
force-pushed
the
readme-opt
branch
2 times, most recently
from
f04d0d0 to
fdd5d97
Compare
|
Amazing, already quite an improvement :) Sounds good on the clarification ticket. |
Included are detailed descriptions of each optional feature plus links.
| arbitrary precision.\ | ||
| See: [6. Numbers](https://tools.ietf.org/html/rfc8259#section-6)\ | ||
| Also see: | ||
| * 2019-09: [4.2. Validation of Numeric Instances](https://json-schema.org/draft/2019-09/json-schema-validation.html#rfc.section.4.2) |
There was a problem hiding this comment.
It's going to be a bit of a pain in the butt to maintain this as new versions come out (since each time that happens we'll have to go find the relevant new section in that draft).
But such is life I suppose, I don't have a better suggestion.
|
I think I'd like to wait for the resolution to #348 (comment) and my response, before committing. |
|
Closing this one, as it's in need of updating but we'll put these in a comment in each file like the suggestion above mentioned. A PR doing so is welcome if no one else gets to it first! |
Closes #25