Skip to content

Ensure "additionalItems" and "additonalProperties" stay same-object only #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
handrews opened this issue Nov 11, 2019 · 3 comments · Fixed by #344
Closed
2 tasks

Ensure "additionalItems" and "additonalProperties" stay same-object only #294

handrews opened this issue Nov 11, 2019 · 3 comments · Fixed by #344
Labels
missing test A request to add a test to the suite that is currently not covered elsewhere.
Milestone
2019-09

Comments

@handrews
Copy link
Contributor

handrews commented Nov 11, 2019 •
edited
Loading

per @awwright on slack, we should have tests to make sure that additionalItems and additionalProperties are only affected by keywords in the same object (as opposed to the new unevaluatedItems and unevaluatedProperties keywords).

  • test for additionalItems
  • test for additionalProperties

These tests would be valid for earlier drafts as well.
@handrews handrews added missing test A request to add a test to the suite that is currently not covered elsewhere. draft support labels Nov 11, 2019
@handrews handrews added this to the 2019-09 milestone Nov 11, 2019
@awwright
Copy link
Member

awwright commented Nov 11, 2019 via email

@handrews handrews mentioned this issue Nov 27, 2019
Closed
@ssilverman
Copy link
Member

ssilverman commented Apr 25, 2020 •
edited
Loading

Aren't these already present in the additionalProperties.json tests? I can see additionalItems tests are missing, though.

@ssilverman
Copy link
Member

ssilverman commented Apr 25, 2020 •
edited
Loading

Actually, it looks like the "peering into" test in additionalProperties.json is broken. I'll fix that here too.
Update: I'm wrong, it looks correct.

@ssilverman ssilverman mentioned this issue Apr 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing test A request to add a test to the suite that is currently not covered elsewhere.
Projects
None yet
Milestone
2019-09
Development

Successfully merging a pull request may close this issue.

[294] Add tests for "additionalProperties" and "additionalItems" ssilverman/JSON-Schema-Test-Suite
3 participants
@awwright @handrews @ssilverman