Skip to content

Update the schema for test suite tests to Draft 2019-09 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Julian opened this issue Sep 29, 2018 · 4 comments
Closed

Update the schema for test suite tests to Draft 2019-09 #238

Julian opened this issue Sep 29, 2018 · 4 comments
Labels
enhancement An enhancement to the tooling or structure of the suite (as opposed to a new test).

Comments

@Julian
Copy link
Member

Julian commented Sep 29, 2018 •
edited
Loading

The current schema is draft 4.

A bit of thought is warranted, and perhaps this interacts with #223, since in theory downstream authors may not support Draft 2019-09 (or any future draft), while they still might care about the schema for tests.

Perhaps this means that the test schema should actually go inside each draft.

Comments welcome of course from anyone with a $0.02 to spare.
@Julian Julian added the missing test A request to add a test to the suite that is currently not covered elsewhere. label Sep 27, 2019
@Julian Julian removed the missing test A request to add a test to the suite that is currently not covered elsewhere. label Oct 12, 2019
@Julian Julian changed the title Update the schema for test suite tests to Draft 7 Update the schema for test suite tests to Draft 2019-09 Oct 12, 2019
@Julian Julian mentioned this issue Nov 22, 2019
Closed
@Relequestual
Copy link
Member

I would say the test schemas should go within each draft!
As painful as it might be, we should still provide tests for draft-4, without preventing nice new things.

We should consider creating a policy...
We still haven't got a good way to reach out to key draft-4 users...

@Julian
Copy link
Member Author

Julian commented Nov 22, 2019

Creating a policy is #223 :) but agreed!

@Relequestual
Copy link
Member

I knew I saw the word policy somewhere, but lost it again =D

Julian added a commit that referenced this issue Feb 22, 2020
@Julian
Future-proof the sanity checker for #238.
49c6197
@ssilverman ssilverman mentioned this issue Apr 25, 2020
Merged
@Julian
Copy link
Member Author

Julian commented Jul 5, 2022

Closed in #565.

@Julian Julian closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement to the tooling or structure of the suite (as opposed to a new test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Julian @Relequestual