Improve regex test cases by including negative tests for unsupported escape characters in them

[zloster]

There is need to add some test cases that check the validation/acceptance of non ECMAScript regular expressions. In the particular case (see the issue here: JamesNK/Newtonsoft.Json.Schema#34) the software accepts escape characters that are not part of the ECMAScript regular expression definitions.

[Julian]

Adding an additional module to the optional test cases would certainly sound fine to me, any chance you'd mind submitting a PR?

Putting it alongside the existing tests wouldn't work, the spec doesn't require ECMAScript compatibility it just recommends it, and many languages would have difficulty with the requirement and these tests.

[zloster]

I've missed the "recommendation" part. My apologies.
I'll try to put some PR about this. Is this file a good place for this?

[Julian]

A file in /optional/ecmascript-regex.json would be good
On Jul 6, 2016 9:59 AM, "Radoslav Petrov" notifications@github.com wrote:

I've missed the "recommendation" part. My apologies.
I'll try to put some PR about this. Is this file
https://github.com/json-schema-org/JSON-Schema-Test-Suite/blob/develop/tests/draft3/optional/jsregex.json
a good place for this?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#119 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAUIXs0eUBYmnOCX55yuA_jMRAakj4dPks5qS7TdgaJpZM4JF3gX
.