sf-field tests, and minor changes to karma.conf #873
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocha reporter is better than dots + progress but especially for diff output as it is needed to see deep comparisons between arrays/objects (for example while looking at wrong keys in the sf-field.directive tests)
|
Has one test issue I commented on the other PR, would love to see that sorted or explained as I would love to merge the content from both PR still open, thank you very much for looking into it! I've had a lot of issues raised without many PRs for a while, so I appreciate your efforts :) |
|
Glad to help :) I use ASF quite intensively and I think I finally know it enough to start contributing. On a side note, the commits here are included in the other PR, I will close this as it is unnecessary (pushed and PRed too eagerly :D) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sf-fieldtests for issue #870Use mocha reporter in karma, for proper expected-actual diff output
Remove duplicate tests from
sf-schemaChecklist
@json-schema-form/angular-schema-form-lead