Improve sfNewArray Directive's titleMapValues Binding #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ray being cleared. Allows multiple checkboxes (array builder) controls to target the same ngModel target array.
|
@kyse thanks for the PR I will try to review it tonight :) |
|
@kyse I migrated the changed to the webpack branch too. Please feel free to check that out and confirm it works using the dist files, there are some tests failing on that branch still so don't expect everything else to work 100% though ;) |
|
Yea, I believe the failing tests are related to the decorators? |
|
@kyse yes there are five failing tests currently four being decorator specific, the other I still have to check. But if there are no major problems when you view the example site then I would be happy to know that :) |
|
Examples seem to be working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes titleMapValues binding in sfNewArray directive. Allows multiple checkboxes controls to target the same ngModel array.
Additional Thoughts
While this helps the main concern of the issue referenced, I'm still a little iffy about this whole setup. It's basically bypassing ngModel when setting values causing trouble for anyone wanting to use a ngModel getterSetter.
Fixes Related issues
Checklist
@json-schema-form/angular-schema-form-lead
sfNewArray: Change titleMapValue binding to prevent ngModel target array being cleared. Allows multiple checkboxes (array builder) controls to target the same ngModel target array.
sfNewArray: Adding test for new titleMapValues binding.