Add check for schema property to prevent form generation failures whe… #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a checkbox is explicitly defined by a developer (and therefore does not have a schema property)
Closed
|
@vinceis1337 looks good, only I forgot to mention that as we are splitting the core out of angular, could you update to use plain javascript instead of the angular.isUndefined? |
|
@Anthropic done! |
|
Thanks, looks good, before I merge I just want to figure out why one test fails, I believe it was already broken, but as it says "schemaForm #defaults() should generate default form def from a schema FAILED" I think it should be checked. Probably the test is just out of date. Thanks for your support @vinceis1337 I'll try to get it sorted soon :) |
|
I have made the change to the core, it will be in the next alpha, thank you @vinceis1337. |
|
@Anthropic thanks for the update, very excited to try out 1.0.0 soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n a checkbox is explicitly defined by a developer (and therefore does not have a schema property)
Fixes: #558