Skip to content

Allow broadcasting of the formName to validate #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2016

Conversation

tomsowerby
Copy link
Contributor

A small change that allows passing the form name during broadcast to limit validation
e.g.

$scope.$broadcast('schemaFormValidate', form.$name);

This allows nested or multiple forms within the same scope, as raised in #169

If no form name is passed it gracefully reverts to current behaviour and validates everything.

Allows passing the form name during broadcast to limit validation
e.g.

    $scope.$broadcast('schemaFormValidate', form.$name);

This allows nested or multiple forms within the same scope.
@sasikumar-sugumar
Copy link

Hi ,
is this part of the latest release build available for download ?

@tomsowerby
Copy link
Contributor Author

It's not been merged into master yet. Just waiting on the project owners to check it over.

@Anthropic
Copy link
Member

Hi @tomsowerby can you update the pull and remove the dist folder from the request for me please? I can then get someone to take a look at it soon. We are re-organising the project and have started planning for life outside of Textalk's management of the project so if you would like to be involved further please let me know.

@tomsowerby
Copy link
Contributor Author

Hi @Anthropic,
The dist folder has been removed. Let me know if you notice any issues, it's been awhile since I've looked at it myself!
I'm happy to stay involved in keeping the project up to date and hopefully moving it to Angular2 (or even elsewhere).

Anthropic added a commit that referenced this pull request Mar 9, 2016
Allow broadcasting of the formName to validate
@Anthropic Anthropic merged commit 1dc6fc8 into json-schema-form:master Mar 9, 2016
@LeonardoGentile
Copy link
Contributor

@Anthropic why was this merged directly into master?
It is indeed available in the src but not in the dist, it is necessary to make a new build, and I tough the best places for src not still included in the dist would be the development branch?

@Anthropic
Copy link
Member

@LeonardoGentile you're right, I was hoping to do a build soon after the pull, but I couldnt catch the dev lead, but I admit I missed that it was not like the other pulls I did that all went to development. I will build it this weekend to dist, we're long overdue for it.

Thank you for letting me know, I appreciate you taking the time.

@LeonardoGentile
Copy link
Contributor

👍

@Anthropic
Copy link
Member

FYI I am looking at adding #655 and will do the release next weekend.

@Anthropic
Copy link
Member

@LeonardoGentile @tomsowerby 0.8.13 is now in bower and the npm release will follow by tomorrow

Anthropic added a commit that referenced this pull request May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants