-
Notifications
You must be signed in to change notification settings - Fork 649
Allow broadcasting of the formName to validate #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allows passing the form name during broadcast to limit validation e.g. $scope.$broadcast('schemaFormValidate', form.$name); This allows nested or multiple forms within the same scope.
Hi , |
It's not been merged into master yet. Just waiting on the project owners to check it over. |
Hi @tomsowerby can you update the pull and remove the dist folder from the request for me please? I can then get someone to take a look at it soon. We are re-organising the project and have started planning for life outside of Textalk's management of the project so if you would like to be involved further please let me know. |
Hi @Anthropic, |
Allow broadcasting of the formName to validate
@Anthropic why was this merged directly into master? |
@LeonardoGentile you're right, I was hoping to do a build soon after the pull, but I couldnt catch the dev lead, but I admit I missed that it was not like the other pulls I did that all went to development. I will build it this weekend to dist, we're long overdue for it. Thank you for letting me know, I appreciate you taking the time. |
👍 |
FYI I am looking at adding #655 and will do the release next weekend. |
@LeonardoGentile @tomsowerby 0.8.13 is now in bower and the npm release will follow by tomorrow |
A small change that allows passing the form name during broadcast to limit validation
e.g.
This allows nested or multiple forms within the same scope, as raised in #169
If no form name is passed it gracefully reverts to current behaviour and validates everything.