Skip to content

schemaFormValidate event doesn't trigger past v0.8.2 #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VladVM opened this issue Jan 21, 2017 · 4 comments
Closed

schemaFormValidate event doesn't trigger past v0.8.2 #828

VladVM opened this issue Jan 21, 2017 · 4 comments

Comments

@VladVM
Copy link

VladVM commented Jan 21, 2017

Problem/question

I am trying to use schemaFormValidate event to make all the form fields validate on external event. After a few hours of digging into my code I've copied a libraries from plunker sample I seen before, and to my surprise I worked. I figured that the behavior changed somewhere after 0.8.2, but I was not able to find any mention on that in the documentation.

Expected behaviour

I expected comment field to notify on validation failure when I click on xxxxx text and schemaFormValidate event is broatcast.

Actual behaviour

In latest version, no indication is happening. in version 0.8.2 it works as expected.

Gist/Plunker/Demo

Example I created for stack overflow question based on v 0.8.2

@Anthropic
Copy link
Member

@VladVM thanks for that, and the plunker, I will try to make a test case for it so it can get fixed :)

@Anthropic
Copy link
Member

I need to add a spec src/directives/schema-validate.directive.spec.js to test that the schemaFormValidate event is both heard and then processed.

Then I can track down and fix where the issue is occurring once it passes with older versions.

@Anthropic Anthropic changed the title schemaFormValidate event doen't seem to trigger validation in versions past 0.8.2 schemaFormValidate event doesn't trigger past v0.8.2 Jan 23, 2017
Anthropic added a commit that referenced this issue Jan 23, 2017
@Anthropic
Copy link
Member

@VladVM could you try it with the current version in development branch? Specifically if you think the test I added in schema-validate.directive.spec.js covers everything?

@VladVM
Copy link
Author

VladVM commented Jan 23, 2017

@Anthropic I've tried it. I've reproduced the issue and then took the current dev version. Now it works as expected with the latest fix.

Spec file covers the exact scenario that was failing. I am not aware of other failing cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants