Skip to content

onChange doesn't fire when form type is array #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davezuch opened this issue Mar 12, 2015 · 7 comments
Closed

onChange doesn't fire when form type is array #295

davezuch opened this issue Mar 12, 2015 · 7 comments

Comments

@davezuch
Copy link

As the title says, if I add an onChange handler to an array field, and then add or remove an item to that array, the handler doesn't fire.

luciformed added a commit to luciformed/angular-schema-form that referenced this issue Apr 29, 2015
@nicklasb
Copy link
Member

Fixed, closing.

@nicklasb
Copy link
Member

nicklasb commented Oct 6, 2016

This is not fixed, the pull request in #374 has not been merged.

@nicklasb nicklasb reopened this Oct 6, 2016
@Anthropic
Copy link
Member

I believe this is fixed in the latest updates (alphas) for the eventual 1.0.0 release.

Please re-open if there are still issues in these versions.

@Anthropic
Copy link
Member

Hmmm the test case in the originally proposed PR fails, re-opening just in case it isn't fixed.

@Anthropic Anthropic reopened this Apr 23, 2017
@Anthropic
Copy link
Member

Nope just fixed the test and it does pass. All good.

Anthropic added a commit that referenced this issue Apr 23, 2017
@santhoslokanath
Copy link

Hi Team,

In which version of release this patch is available. I am using bower to install and after running bower install. the patch code mentioned in this case(i.e onChange for array) is not available.

Please, let me know what I have do to get patch through bower.

Thanks,
Santhosh Lokanath

@Anthropic
Copy link
Member

@santhoslokanath as mentioned above it is fixed in the alphas, it is not in a release yet, I suggest using npm and pulling the alpha version. Bower won't be supported much longer I expect as they recommend using yarn on their own homepage https://bower.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants