Skip to content

Add additional unit tests #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sudo-jaa
Copy link
Contributor

@sudo-jaa sudo-jaa commented Nov 5, 2018

I've been taking a look at your project and have identified some classes which could potentially benefit from increased code coverage. The regression tests contained in this PR should catch some edge cases that haven't yet been covered by your existing tests for these classes. They'll help you identify any unexpected behaviour in your code as you continue to develop your project.

I'd be happy to help create some more tests for your project should you wish!

@codecov-io
Copy link

Codecov Report

Merging #217 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   68.31%   68.46%   +0.14%     
==========================================
  Files         107      107              
  Lines        7334     7334              
  Branches     1388     1388              
==========================================
+ Hits         5010     5021      +11     
+ Misses       1868     1867       -1     
+ Partials      456      446      -10
Impacted Files Coverage Δ
src/main/java/com/jsoniter/spi/OmitValue.java 96.51% <0%> (+9.3%) ⬆️
src/main/java/com/jsoniter/spi/Slice.java 96.42% <0%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e8df1...6e56d6d. Read the comment docs.

@taowen taowen merged commit e48a7a1 into json-iterator:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants