Skip to content

feat: add duration pipe #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

feat: add duration pipe #139

merged 1 commit into from
Mar 11, 2025

Conversation

json-derulo
Copy link
Owner

@json-derulo json-derulo commented Aug 30, 2023

Adds a pipe to transform durations based on the Intl.DurationFormat browser API. Tests are failing currently due to missing implementation of the API by some browsers. Status can be tracked here:

Closes #100

@json-derulo json-derulo added enhancement New feature or request blocked Blocked by some external factor labels Aug 30, 2023
@json-derulo json-derulo force-pushed the feature/duration-pipe branch 2 times, most recently from 92dafdd to 6ffe468 Compare September 1, 2023 17:52
@json-derulo json-derulo force-pushed the feature/duration-pipe branch from 6ffe468 to 598a15c Compare September 8, 2023 11:47
@json-derulo json-derulo force-pushed the feature/duration-pipe branch from 598a15c to c7aaa94 Compare December 7, 2024 13:35
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (44f283e) to head (04fbdb6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        22    +2     
  Lines          154       166   +12     
  Branches        35        38    +3     
=========================================
+ Hits           154       166   +12     
Files with missing lines Coverage Δ
...lib/duration/intl-duration-pipe-default-options.ts 100.00% <100.00%> (ø)
...script-intl/src/lib/duration/intl-duration.pipe.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@json-derulo json-derulo removed the blocked Blocked by some external factor label Mar 5, 2025
@json-derulo json-derulo marked this pull request as ready for review March 5, 2025 13:34
@json-derulo json-derulo force-pushed the feature/duration-pipe branch 7 times, most recently from 1b210d6 to 6a1f68b Compare March 10, 2025 09:48
@json-derulo json-derulo force-pushed the feature/duration-pipe branch from 6a1f68b to 04fbdb6 Compare March 11, 2025 05:52
@json-derulo json-derulo merged commit 25c4380 into main Mar 11, 2025
10 checks passed
@json-derulo json-derulo deleted the feature/duration-pipe branch March 11, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New duration pipe
1 participant