add returning promise example for returns tag
#175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hegemonic
reviewed
Aug 1, 2017
content/en/tags-returns.md
Outdated
| * Returns the sum of a and b | ||
| * @param {Number} a | ||
| * @param {Number} b | ||
| * @returns {Promise<Number>} Promise object represents the sum of a and b |
There was a problem hiding this comment.
nit: change Number to number in all three type expressions
There was a problem hiding this comment.
@hegemonic Done. Thank you for the suggestions.
content/en/tags-returns.md
Outdated
| * @returns {Promise<Number>} Promise object represents the sum of a and b | ||
| */ | ||
| function sumAsync(a, b) { | ||
| return new Promise(function(resolve, reject){ |
zhengzongyi
force-pushed
the
add_returning_promise_example
branch
from
89e4833 to
c95c3bf
Compare
|
Thanks for making the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.