Test Coverage (fetch, updateMany/createMany, addAction(s))

[pik]

So not all of the top level opts such as basePath per docs are getting merged into _opts in addAction. The following PR should fix it by missing both of them, also adding a test since addAction was missing coverage.

A few other things (maybe worth opening an issue for) - one thing I'm not a huge fan of is the large dynamic function definition in addAction, it may be nicer to have a static function and either bind, or store some of the default arguments to be passed to it.

Another is that addAction is a function in an extension that relies mapper / store introspection to be correct. Would a more general path-way to to allow action: {} definitions in the mapper which the applied / registered adapters be allowed to absorb into their own actions without requiring them to introspect the core framework?

[pik]

because endpoint is always appended to basePath

[jmdobry]

endppoint => endpoint

[pik]

Another point - should the action return an object if a mapper is specified in options? Currently it's hard for me to tell that there is much advantage to using addAction over declaring a function on the mapper manually e.g.

getTeacherReports(reportId) {
  return adapter.GET(`reports/schools/${reportId}/teachers`)
    .then((response) => {
      /* instantiate a record from response.data*/
    })
},

[jmdobry]

I personally just add my own functions to mappers, but a lot of people clamored for this declarative HTTP action syntax.

[pik]

It would be good to de-duplicate these 3 files. I would have preferred to do this via. es6 but I haven't gotten both build pipelines to work correctly with that =/

[codecov-io]

Current coverage is 93.87% (diff: 100%)

Merging #56 into master will increase coverage by 0.54%

@@             master        #56   diff @@
==========================================
  Files             1          1          
  Lines            45         49     +4   
  Methods           7          7          
  Messages          0          0          
  Branches          6          6          
==========================================
+ Hits             42         46     +4   
  Misses            3          3          
  Partials          0          0          

Powered by Codecov. Last update 9d8ca3a...14f7936

[pik]

Not sure these are worth keeping in the library - but at least added tests for coverage stats.

[pik]

More tests #36

[pik]

Skipping the mocha test because the fetch polyfill for Node is not actually compatible with the browser fetch. We would need to fork the polyfill or have different fetch behaviors depending on node/browser.

[jmdobry]

why?