Allow urlPath override for httpAdapter #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@internalfx Can you please remove the changes to |
|
@jmdobry sure thing |
| if (method === 'find' || method === 'update' || method === 'destroy') { | ||
| args.push(id); | ||
| if (isString(options.urlPath)) { | ||
| return makePath.apply(DSUtils, [options.basePath || _this.defaults.basePath || resourceConfig.basePath].concat(options.urlPath.split('/'))); |
There was a problem hiding this comment.
I don't think you have to split options.urlPath, I think you can just make it the second item in the array passed to madePath.apply.
jmdobry
changed the title
|
arrggg. I think I've now totally messed up my repo. Git is great until you need to change history. And I'm not that good at git. |
|
How about I just throw your changes into a commit so I can cut a release? |
|
@jmdobry got it. |
jmdobry
added a commit
that referenced
this pull request
Sep 12, 2015
Allow urlPath override for httpAdapter
|
I only see 1 commit. let me look |
|
nope, refreshed |
|
ok, cool |
|
I also made your changes to the array |
|
Needed to remove the |
|
@jmdobry I'm also simultaneously migrating a chat server. Perhaps my attention was a little divided. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to specify a
urlPathoption when running an async method.Example: