Skip to content

Make params argument optional #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kentcdodds opened this issue May 30, 2014 · 1 comment
Closed

Make params argument optional #70

kentcdodds opened this issue May 30, 2014 · 1 comment
Assignees

Comments

@kentcdodds
Copy link
Contributor

There is a use case where I don't want to include query parameters. Currently, I am forced to do: DS.findAll('user', {}). I would prefer to leave off the object if I don't have any query params. This isn't a really big deal, except it looks like the request is getting sent with query=%7B%7D (aka query={}) which is not desirable or necessary in this case. I would much rather angular-data be smart enough to allow me to not have any query param at all if I don't specify params.

@jmdobry
Copy link
Member

jmdobry commented May 30, 2014

There are three lines in src/adapters/http.js that would need to be reworked to fix this (findAll, updateAll, destroyAll).

jmdobry added a commit that referenced this issue May 30, 2014
@jmdobry jmdobry changed the title DS.findAll('user') Make params argument optional May 30, 2014
@jmdobry jmdobry self-assigned this May 30, 2014
@jmdobry jmdobry closed this as completed May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants