Skip to content

Export the module name #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kentcdodds opened this issue Feb 23, 2015 · 3 comments · Fixed by #312
Closed

Export the module name #308

kentcdodds opened this issue Feb 23, 2015 · 3 comments · Fixed by #312

Comments

@kentcdodds
Copy link
Contributor

See my post about it and this angular.js PR comment for reasons as to why it's a good idea. Basically, enables this:

angular.module('myModule', [require('js-data-angular')]);
@kentcdodds
Copy link
Contributor Author

With the angular team moving to this method, I've been able to move most of my dependencies to use this method. Would love to see js-data-angular join the ranks there :D

@jmdobry
Copy link
Member

jmdobry commented Mar 3, 2015

PR?
On Mar 3, 2015 1:36 PM, "Kent C. Dodds" [email protected] wrote:

With the angular team moving to this method, I've been able to move most
of my dependencies to use this method. Would love to see js-data-angular
join the ranks there :D


Reply to this email directly or view it on GitHub
#308 (comment)
.

@kentcdodds
Copy link
Contributor Author

Totally reasonable. One sec...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants