Skip to content

bower.json - angular not listed as non-dev dependency #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisronline opened this issue Oct 24, 2014 · 1 comment
Closed

bower.json - angular not listed as non-dev dependency #215

chrisronline opened this issue Oct 24, 2014 · 1 comment
Assignees

Comments

@chrisronline
Copy link

I'm using this tool in my build process: https://github.com/ck86/main-bower-files

It iterates through all dependencies bower.json files to build a dependency map and when I include your project, it sorts angular-data before angular which is because you don't have angular listed as a non-dev dependency. The main-bower-files tool has a way to override this, but I just wanted to give you a heads up.

Edit: It also appears that angular-cache is a required dependency, but just listed as a dev dependency too.

Cheers

@jmdobry
Copy link
Member

jmdobry commented Oct 24, 2014

Thanks

@jmdobry jmdobry added the bug label Oct 31, 2014
@jmdobry jmdobry self-assigned this Oct 31, 2014
@jmdobry jmdobry changed the title bower.json - angular not listed as non-dev depenency bower.json - angular not listed as non-dev dependency Oct 31, 2014
jmdobry added a commit that referenced this issue Oct 31, 2014
Stable Version 1.1.0.
@jmdobry jmdobry closed this as completed Oct 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants