Skip to content

Commit 06e2793

Browse files
mroeschkeMatt Roeschke
and
Matt Roeschke
authored
Change defaults for rolling/expanding.apply engine kwargs to None (pandas-dev#35374)
* Change defaults for rolling/expanding.apply engine kwargs to None * Add whatsnew Co-authored-by: Matt Roeschke <[email protected]>
1 parent 3e88e17 commit 06e2793

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

doc/source/whatsnew/v1.1.0.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ Other enhancements
338338
- :meth:`read_csv` now accepts string values like "0", "0.0", "1", "1.0" as convertible to the nullable boolean dtype (:issue:`34859`)
339339
- :class:`pandas.core.window.ExponentialMovingWindow` now supports a ``times`` argument that allows ``mean`` to be calculated with observations spaced by the timestamps in ``times`` (:issue:`34839`)
340340
- :meth:`DataFrame.agg` and :meth:`Series.agg` now accept named aggregation for renaming the output columns/indexes. (:issue:`26513`)
341-
- ``compute.use_numba`` now exists as a configuration option that utilizes the numba engine when available (:issue:`33966`)
341+
- ``compute.use_numba`` now exists as a configuration option that utilizes the numba engine when available (:issue:`33966`, :issue:`35374`)
342342
- :meth:`Series.plot` now supports asymmetric error bars. Previously, if :meth:`Series.plot` received a "2xN" array with error values for `yerr` and/or `xerr`, the left/lower values (first row) were mirrored, while the right/upper values (second row) were ignored. Now, the first row represents the left/lower error values and the second row the right/upper error values. (:issue:`9536`)
343343

344344
.. ---------------------------------------------------------------------------

pandas/core/window/expanding.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def apply(
137137
self,
138138
func,
139139
raw: bool = False,
140-
engine: str = "cython",
140+
engine: Optional[str] = None,
141141
engine_kwargs: Optional[Dict[str, bool]] = None,
142142
args=None,
143143
kwargs=None,

pandas/core/window/rolling.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1344,7 +1344,7 @@ def apply(
13441344
self,
13451345
func,
13461346
raw: bool = False,
1347-
engine: str = "cython",
1347+
engine: Optional[str] = None,
13481348
engine_kwargs: Optional[Dict] = None,
13491349
args: Optional[Tuple] = None,
13501350
kwargs: Optional[Dict] = None,

0 commit comments

Comments
 (0)