Skip to content

change: lineage query visualization experience enhancement #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 15, 2022

Conversation

ytlee93
Copy link
Collaborator

@ytlee93 ytlee93 commented Aug 12, 2022

Issue #, if available:

Description of changes:
lineage query visualization experience enhancement, including embedding legend to html file generate by pyvis and adding in arn information when hover on node
image

Testing done:
tox -e black-format & tox -e flake8,pylint,twine,black-check,docstyle --parallel all
tox -r -e py39 tests/integ/sagemaker/lineage/test_lineage_visualize.py
tox -e py39 tests/unit/sagemaker/lineage

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ytlee93 ytlee93 merged commit f761a98 into jkasiraj:master Aug 15, 2022
ytlee93 added a commit to ytlee93/sagemaker-python-sdk that referenced this pull request Aug 15, 2022
Merge pull request jkasiraj#9 from ytlee93/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants