feature: query lineage visualizer advanced styling & interactive component handling #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edge.association_type added style changes of graph
Merge pull request #3 from ytlee93/master
jkasiraj
reviewed
Jul 20, 2022
|
The graph looks nice! |
jkasiraj
approved these changes
Jul 21, 2022
src/sagemaker/lineage/query.py
Outdated
| ), | ||
| # legend section | ||
| self.html.Div( | ||
| [self._create_legend_component(k, v) for k, v in self.entity_color.items()] |
There was a problem hiding this comment.
Won't this result in the string TrialComponent being shown instead of Trial Component? Could either string split on capitalization or just include the title in the config as well as the selector id
jkasiraj
approved these changes
Jul 21, 2022
ytlee93
referenced
this pull request
in ytlee93/sagemaker-python-sdk
Jul 27, 2022
Merge pull request #4 from ytlee93/master
ytlee93
added a commit
that referenced
this pull request
Aug 5, 2022
Merge pull request #6 from ytlee93/master
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
tox -e black-format & tox -e flake8,pylint,twine,black-check,docstyle --parallel all
tox -e py39 tests/unit/sagemaker/lineage
tox -e py39 tests/integ/sagemaker/lineage
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.