Skip to content

feature: add __str__ methods to queryLineage output classes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

ytlee93
Copy link
Collaborator

@ytlee93 ytlee93 commented Jul 1, 2022

Issue #, if available:

Description of changes: add str methods to queryLineage output classes Edge, Vertex', and LineageQueryResult` for a string representation of an instance, it will be evoked when calling print() on the object to have a more informative output

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Collaborator

@Snoyark Snoyark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the 3 commits into one to describe the overall change?

@@ -130,6 +134,10 @@ def __eq__(self, other):
and self.lineage_source == other.lineage_source
)

def __str__(self):
"""Define string representation of ``Vertex``."""
return (str(self.__dict__))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this look like?

@ytlee93 ytlee93 merged commit 6d005e2 into jkasiraj:master Jul 7, 2022
ytlee93 added a commit that referenced this pull request Jul 26, 2022
Merge pull request #3 from ytlee93/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants