Skip to content

Should this be initLoginFlow instead? #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maxisam opened this issue Mar 11, 2020 · 2 comments
Closed

Should this be initLoginFlow instead? #32

maxisam opened this issue Mar 11, 2020 · 2 comments

Comments

@maxisam
Copy link
Contributor

maxisam commented Mar 11, 2020

sample-angular-oauth2-oidc-with-auth-guards/src/app/core/auth.service.ts

Line 179 in c73b0f2

this.oauthService.initImplicitFlow(encodeURIComponent(targetUrl || this.router.url));

maxisam added a commit to maxisam/sample-angular-oauth2-oidc-with-auth-guards that referenced this issue Mar 11, 2020
@maxisam
fix: use initLoginFlow for code flow
f513eb0 
jeroenheijmans#32
@maxisam maxisam mentioned this issue Mar 11, 2020
Merged
@jeroenheijmans
Copy link
Owner

Yes, that seems to be correct. Will double check later and merge, thx for this!

@jeroenheijmans
Copy link
Owner

Thanks @maxisam, worked like a charm!

jeroenheijmans pushed a commit that referenced this issue Mar 28, 2020
@maxisam @jeroenheijmans
fix: use initLoginFlow for code flow
3b13ef9 
#32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxisam @jeroenheijmans