Skip to content

feat: addressing comments in initial PR #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2022
Merged

feat: addressing comments in initial PR #2

merged 1 commit into from
Sep 16, 2022

Conversation

jeffrey-baker-vg
Copy link
Owner

@jeffrey-baker-vg jeffrey-baker-vg commented Sep 15, 2022 •
edited
Loading

Description of your changes

How to verify this change

Related issues, RFCs

Issue number:

PR status

Is this ready for review?: NO
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeffrey-baker-vg jeffrey-baker-vg merged commit a2922e8 into main Sep 16, 2022
@vgphoenixcampos vgphoenixcampos self-requested a review September 16, 2022 13:08
vgphoenixcampos
vgphoenixcampos reviewed Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@vgphoenixcampos vgphoenixcampos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgphoenixcampos vgphoenixcampos vgphoenixcampos left review comments

@KevenFuentes9 KevenFuentes9 KevenFuentes9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffrey-baker-vg @vgphoenixcampos @KevenFuentes9