Skip to content

Fix #226: angle map for chamaeleon64 #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Conversation

jasoncoon
Copy link
Owner

@jasoncoon jasoncoon commented Dec 13, 2021

Fixed a couple of typos.
@jasoncoon jasoncoon requested a review from henrygab December 13, 2021 23:24
@jasoncoon jasoncoon self-assigned this Dec 13, 2021
@jasoncoon jasoncoon merged commit 6f1b748 into main Dec 14, 2021
@jasoncoon jasoncoon deleted the jcoon/fix-c64-angle-map branch December 14, 2021 01:55
@henrygab
Copy link
Collaborator

Sorry for delay, I was writing some code to verify that this wasn't an accidental use of degrees instead of the "F256" unit (as I'm now calling it ... where 256 F256s == 360 degrees). I was good with the change, but didn't want to bother you with this question if I could figure out the answer myself. But, then I got lost learning Python. 🤣

Copy link
Collaborator

@henrygab henrygab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that you subtracted 255 from the values, rather than 256 ... was this intentional? It should have a noticable effect on ... the effects, but just curious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chamaeleon64: Angles -- narrowing conversion of type warnings
2 participants