Skip to content

changes on folder placement for angular and all js files #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

changes on folder placement for angular and all js files #9

wants to merge 9 commits into from

Conversation

infacq
Copy link

@infacq infacq commented May 29, 2015

No description provided.

@jadjoubran
Copy link
Owner

Hi @infacq
Thank you so much for this pull request!
Unfortunately I can't accept it because of the following issues:

  • bower_components were committed at a certain point and they're now available in the history of the repository (over 466 files)
  • Your gulpfile configuration requires changing the gulp configuration everytime you add a new less file, which means you have to edit it, stop the current gulp watch command and restart it.
  • compiled css files were also comitted in the public directory which introduces unnecessary conflicts

If you want, we can plan another pull request which only introduces 1 change per PR. We can do that in the issues to make sure that it can be merged.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants