CI : Branch 3.2.1's build is not passing

[chihab]

• I'm submitting a ...
• bug report
• feature request
• support request
• build not passing on 3.2.1

branch 3.2.1's build is not passing on travis-ci since last commit.

I tried to figure out what is happening, maybe related to .env file not present but can't understand why it would work before and also for default branch (master) then...

What is your ci/build workflow ? Do you create new branch for each fix then push it to github to activate the ci ?

Thanks

• Laravel & Angular version: 3.2.1

[jadjoubran]

Hi @chihab
Thanks for contributing!
It's failing that critical.css is not found, which is introduced in branch feature-pwa that was recently merged into master.. I don't exactly know why this is happening

I normally have them as tags.. so when there was an issue in tag 3.2.0, I checkouted to tags/3.2.0, made a fix and tagged 3.2.1
Maybe this line needs to be fixed?
https://github.com/jadjoubran/laravel5-angular-material-starter/blob/3.2.1/.travis.yml#L25

[chihab]

Indeed, on Travis build steps, we're telling Travis to get a fresh install from dev-master which is not the branch we'd really like to test.

Here what happens:

First Travis clones our branch 3.2.1:
git clone --depth=50 --branch=3.2.1 https://github.com/jadjoubran/laravel5-angular-material-starter.git

Then in the same folder, we do a
composer create-project jadjoubran/laravel5-angular-material-starter=dev-master

and then go into that latter to do the build and testings. This one is the master branch, not the stable 3.2.1. Hence the critical.css not supposed to be here.

The way we should probably do it is
To launch the build inside the cloned repo which matches the exact version we're willing to test. The composer create-project is redundant and probably unwanted here (as explained). Btw, create-project is a git clone + composer install, so it is better imo to do pre-install and post-install steps rather than pre-create-project and post-create-project, the former applies to both.

It would also be better to have:

• on the Travis install step: all the install dependencies stuff
• on the Travis script step: only the actual build commands (gulp and why not unit tests)

Something like:

install:
  - composer install && npm install -g gulp bower && npm install && bower install

script:  
  - php artisan migrate --force && gulp && vendor/bin/phpunit

If we follow this steps, we'll have an issue on build due to key and jwt generation not done because it is supposed to be done on composer create-project, it should be moved to post-install phase on composer.json

Here are the proposed fixed files:
https://github.com/chihab/laravel5-angular-material-starter/blob/branch-3.2.1/.travis.yml
https://github.com/chihab/laravel5-angular-material-starter/blob/branch-3.2.1/composer.json

Shouldn't we specify (in composer.json I suppose) the project's current version. I didn't find a way to know which version is my current project folder.

[jadjoubran]

Okay now it makes sense, thanks for the explanation!
Could you send a PR with the fixes to 3.2.1? And then after testing it and making sure it works, we can port it to master
Btw regarding the version, most packages don't have it because of the reasons stated in the docs

[chihab]

Olay @jadjoubran, I'll send a PR asap.

[chihab]

@jadjoubran
I'll send a PR once #358 is fixed and phpunit tests pass successfully on master branch.

[jadjoubran]

@chihab I will fix this, because I guess it's easier from my side
I'm traveling tonight though so I'll try as soon as possible 😄

[chihab]

Okay @jadjoubran. Have a nice trip. :)

[jadjoubran]

@chihab I just discovered an issue with this approach.. running composer install locally would delete the files that we were deleting on composer create-project..