BUG: 2D ndarray of dtype 'object' is always copied upon construction (pandas-dev#39263)

Author: irgolic

doc/source/whatsnew/v1.3.0.rst

@@ -237,6 +237,7 @@ Datetimelike
 - Bug in comparisons between :class:`Timestamp` object and ``datetime64`` objects just outside the implementation bounds for nanosecond ``datetime64`` (:issue:`39221`)
 - Bug in :meth:`Timestamp.round`, :meth:`Timestamp.floor`, :meth:`Timestamp.ceil` for values near the implementation bounds of :class:`Timestamp` (:issue:`39244`)
 - Bug in :func:`date_range` incorrectly creating :class:`DatetimeIndex` containing ``NaT`` instead of raising ``OutOfBoundsDatetime`` in corner cases (:issue:`24124`)
+- Bug in :class:`DataFrame` constructor always copying 2D object arrays
 
 Timedelta
 ^^^^^^^^^

pandas/core/internals/construction.py

@@ -236,23 +236,20 @@ def init_ndarray(values, index, columns, dtype: Optional[DtypeObj], copy: bool):
     # on the entire block; this is to convert if we have datetimelike's
     # embedded in an object type
     if dtype is None and is_object_dtype(values.dtype):
-
         if values.ndim == 2 and values.shape[0] != 1:
-            # transpose and separate blocks
-
-            dvals_list = [maybe_infer_to_datetimelike(row) for row in values]
-            for n in range(len(dvals_list)):
-                if isinstance(dvals_list[n], np.ndarray):
-                    dvals_list[n] = dvals_list[n].reshape(1, -1)
-
-            from pandas.core.internals.blocks import make_block
-
-            # TODO: What about re-joining object columns?
-            block_values = [
-                make_block(dvals_list[n], placement=[n], ndim=2)
-                for n in range(len(dvals_list))
+            maybe_datetime = [
+                maybe_infer_to_datetimelike(instance) for instance in values
             ]
-
+            # don't convert (and copy) the objects if no type inference occurs
+            if any(
+                not is_dtype_equal(instance.dtype, values.dtype)
+                for instance in maybe_datetime
+            ):
+                return create_block_manager_from_arrays(
+                    maybe_datetime, columns, [columns, index]
+                )
+            else:
+                block_values = [values]
         else:
             datelike_vals = maybe_infer_to_datetimelike(values)
             block_values = [datelike_vals]

pandas/tests/frame/test_constructors.py

@@ -1845,6 +1845,14 @@ def test_constructor_series_copy(self, float_frame):
 
         assert not (series["A"] == 5).all()
 
+    def test_object_array_does_not_copy(self):
+        a = np.array(["a", "b"], dtype="object")
+        b = np.array([["a", "b"], ["c", "d"]], dtype="object")
+        df = DataFrame(a)
+        assert np.shares_memory(df.values, a)
+        df2 = DataFrame(b)
+        assert np.shares_memory(df2.values, b)
+
     def test_constructor_with_nas(self):
         # GH 5016
         # na's in indices