Skip to content

Added coverage per @lathonez #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2017
Merged

Added coverage per @lathonez #68

merged 3 commits into from
Sep 5, 2017

Conversation

leifwells
Copy link
Contributor

This Pull Request is a replacement for @lathonez's PR #12 for adding Code Coverage for tests. My inability to merge that PR led to my recreating the changes and placing them into a new PR.

All the hard work on this PR was performed by @lathonez. Thanks, Stephen, for the original PR, your leadership, and all the work you are doing with clicker.

With this update, developers can run npm run test-coverage which will run the project's unit tests with Karma and produce documentation that gives guidance on how well the project's tests cover the code.

Example Image of Completed Code Coverage

The documentation is created inside the /coverage folder (ignored by git).

@leifwells leifwells merged commit ca0da30 into ionic-team:master Sep 5, 2017
@leifwells leifwells deleted the chore/validating-coverage branch September 5, 2017 20:01
@lathonez
Copy link
Contributor

lathonez commented Sep 5, 2017

@leifwells thank you for the plaudits. Good to see this repo has had the expected uptake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants