Skip to content

feat(types): add TypeScript definitions #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Conversation

araxor
Copy link
Contributor

@araxor araxor commented Feb 14, 2025

Closes #606

Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: 605b1cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@intlify/eslint-plugin-vue-i18n Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Did the emitted types work fine in your environment?

@araxor
Copy link
Contributor Author

araxor commented Feb 18, 2025

I just checked by packaging manually:

pnpm run build
pnpm pack

Then I installed the package in my project:

cd /path/to/my/project
npm uninstall '@intlify/eslint-plugin-i18n'
npm install /path/to/intlify-eslint-plugin-vue-i18n-4.0.0-next.1.tgz

It works correctly. There is no error anymore with TypeScript/vue-tsc and the types are visible in my IDE (WebStorm).

@ota-meshi
Copy link
Member

Thank you for checking. I think the PR change is probably fine, but I'd like to investigate why the error is occurring in CI.

@ota-meshi ota-meshi merged commit 6c750f8 into intlify:master Mar 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit type declarations
2 participants