This repository was archived by the owner on Apr 8, 2025. It is now read-only.
adding deployment file #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eoghan1232
reviewed
Sep 27, 2023
Makefile
Outdated
| @@ -13,6 +13,7 @@ help: | |||
| @echo "make build - Build UserSpace CNI container." | |||
| @echo "make deploy - Copy binary from container to host: /opt/cni/bin." | |||
| @echo "make all - build and deploy" | |||
| @echo "make rollout - kubectl apply daemonset" | |||
There was a problem hiding this comment.
I'm not a fan of calling it rollout, I would prefer make deploy for something like this...
can we rename to deploy and choose another name for the other command?
"make copy" ?
kubernetes/userspace-daemonset.yml
Outdated
| - name: cnibin | ||
| hostPath: | ||
| path: /opt/cni/bin | ||
| containers: |
There was a problem hiding this comment.
so the init container copies the binary, and then it goes into the main container, which is a pause container, thus releasing resources.
correct?
Eoghan1232
reviewed
Sep 28, 2023
johnoloughlin
force-pushed
the
deployment
branch
from
088c34e to
b901360
Compare
Signed-off-by: John O'Loughlin <[email protected]>
johnoloughlin
force-pushed
the
deployment
branch
from
b901360 to
40da9a5
Compare
Eoghan1232
approved these changes
Sep 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.