Removed usage of itertools
#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itertools crate was used for ergonomic join on the iterator of strings. Changed this to use join on the vec of strings from the std lib, and droped a dependecy of the crate. Std lib join should even be more performant, since it prealocates the string length correctly, while itertools is doing the best effort it can.
|
Thank you for this PR! |
|
@mvucenovic Thank you very much for your contribution. I hope you have a successful rest of Hacktoberfest. Stay Hacking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Itertools crate was used for ergonomic join on the iterator of strings. Changed this to use join on the vec of strings from the std lib, and dropped a dependency of the crate. Std lib join should even be more performant, since it preallocates the string length correctly, while itertools is doing the best effort it can.
Fixes #10