Skip to content

fix: Remove Content-Encoding=Identity as the header as it violates the RFC #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

tj---
Copy link
Contributor

@tj--- tj--- commented Jul 20, 2023

Closes open-telemetry/opentelemetry-collector#8114

Proposed Changes

Content-Encoding: identity is incorrect and must not be set. As a result, the client is failing to write metrics to the OpenTelemetry Collector v0.81.0
RFC snippet: open-telemetry/opentelemetry-collector#8114 (comment)

This change removes the hardcoded Content-Encoding: identity so that the remote servers don't reject the request. The go library of influx-client also does not add this header.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar changed the title Remove Content-Encoding=Identity as the header as it violates the RFC fix: Remove Content-Encoding=Identity as the header as it violates the RFC Jul 20, 2023
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tj--- thanks for your PR 👍

Can you please satisfy our checklist, after that we will merge this PR:

image

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (992ff7c) 90.30% compared to head (53b3594) 90.30%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          39       39           
  Lines        3456     3456           
=======================================
  Hits         3121     3121           
  Misses        335      335           
Impacted Files Coverage Δ
influxdb_client/client/write_api.py 97.30% <ø> (ø)
influxdb_client/client/write_api_async.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tj---
Copy link
Contributor Author

tj--- commented Jul 20, 2023

Can you please satisfy our checklist, after that we will merge this PR:

@bednar Sorry, I may have messed up the commit messages. But the rest of the points should be in place now.

@tj--- tj--- requested a review from bednar July 20, 2023 12:27
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tj--- thanks again for your PR 👍

LGTM 🚀

@bednar bednar merged commit dea6dec into influxdata:master Jul 21, 2023
@bednar bednar added this to the 1.35.0 milestone Jul 21, 2023
@bednar bednar modified the milestones: 1.35.0, 1.37.0 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change in handling Content-Encoding:"identity" in version v0.81.0
3 participants