-
Notifications
You must be signed in to change notification settings - Fork 185
fix: Remove Content-Encoding=Identity as the header as it violates the RFC #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #595 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 39 39
Lines 3456 3456
=======================================
Hits 3121 3121
Misses 335 335
☔ View full report in Codecov by Sentry. |
@bednar Sorry, I may have messed up the commit messages. But the rest of the points should be in place now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tj--- thanks again for your PR 👍
LGTM 🚀
Closes open-telemetry/opentelemetry-collector#8114
Proposed Changes
Content-Encoding: identity
is incorrect and must not be set. As a result, the client is failing to write metrics to the OpenTelemetry Collector v0.81.0RFC snippet: open-telemetry/opentelemetry-collector#8114 (comment)
This change removes the hardcoded
Content-Encoding: identity
so that the remote servers don't reject the request. The go library of influx-client also does not add this header.Checklist
pytest tests
completes successfully